Skip to content

[SPARK-51572] Support binary type in show and collect #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-51572] Support binary type in show and collect #26

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 20, 2025 •
edited
Loading

What changes were proposed in this pull request?

This PR aims to support binary type in show and collect.

Why are the changes needed?

Like the other client, binary type values shows in an array style.

$ bin/pyspark --remote sc://localhost:15002
>>> sql("SELECT binary('abc')").show()
+----------+
|       abc|
+----------+
|[61 62 63]|
+----------+

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Could you review this, @LuciferYang ?

LuciferYang
LuciferYang approved these changes Mar 21, 2025
View reviewed changes
Copy link

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @LuciferYang and @viirya .
Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-51572 branch March 21, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

@LuciferYang LuciferYang LuciferYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dongjoon-hyun @viirya @LuciferYang